New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Superflore OE Recipe Generation Scheme r44 #255

Closed

shr-project opened this issue Nov 20, 2019 · 0 comments

Milestone

Contributor

shr-project commented Nov 20, 2019

it's only a draft now for implementing layer version 3, but these changes cover most of it (at least as-is now)

shr-project added a commit to shr-project/superflore that referenced this issue


          Generate recipes in meta-ros-<distro> instead of generated-recipes-<d…

ac32726

…istro>

* yocto_recipe: generate top inherit with specific ROS_DISTRO instead of variable
* this allows to mix layers from different ROS_DISTROs where each recipe
  inherits the right bbclass to set common configuration for its ROS_DISTRO

* yocto_recipe.py: don't generate include lines for various .inc files
* we'll use normal bbappends instead

* bitbake: include ros_version in layer name
* e.g. meta-ros-melodic will be meta-ros1-melodic now

* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

shr-project added a commit to shr-project/superflore that referenced this issue


          yocto_recipe.py: drop ROS_COMPONENT_TYPE

92c1ddb

* we no longer need to distinguish between ros1 and ros2 components
* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

shr-project added a commit to shr-project/superflore that referenced this issue


          Generate recipes in meta-ros-<distro> instead of generated-recipes-<d…

f1bd664

…istro>

* yocto_recipe: generate top inherit with specific ROS_DISTRO instead of variable
* this allows to mix layers from different ROS_DISTROs where each recipe
  inherits the right bbclass to set common configuration for its ROS_DISTRO

* yocto_recipe.py: don't generate include lines for various .inc files
* we'll use normal bbappends instead

* bitbake: include ros_version in layer name
* e.g. meta-ros-melodic will be meta-ros1-melodic now

* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

shr-project added a commit to shr-project/superflore that referenced this issue


          yocto_recipe.py: drop ROS_COMPONENT_TYPE

979f9bb

* we no longer need to distinguish between ros1 and ros2 components
* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

shr-project added a commit to shr-project/superflore that referenced this issue


          yocto_recipe.py: append to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

9d56094

* define ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<DISTRO>
  and then append it to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

* that way when e.g. melodic and dashing are enabled at the same time
  and their generated ros-distro.inc parsed,
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS will contain union of their
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<DISTRO> while still keeping
  the separate list available if we need it for something else

* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

shr-project added a commit to shr-project/superflore that referenced this issue


          Generate recipes in meta-ros-<distro> instead of generated-recipes-<d…

1f2adab

…istro>

* yocto_recipe: generate top inherit with specific ROS_DISTRO instead of variable
* this allows to mix layers from different ROS_DISTROs where each recipe
  inherits the right bbclass to set common configuration for its ROS_DISTRO

* yocto_recipe.py: don't generate include lines for various .inc files
* we'll use normal bbappends instead

* bitbake: include ros_version in layer name
* e.g. meta-ros-melodic will be meta-ros1-melodic now

* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

shr-project added a commit to shr-project/superflore that referenced this issue


          yocto_recipe.py: drop ROS_COMPONENT_TYPE

325a202

* we no longer need to distinguish between ros1 and ros2 components
* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

shr-project added a commit to shr-project/superflore that referenced this issue


          yocto_recipe.py: append to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

9bbbfa7

* define ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<DISTRO>
  and then append it to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

* that way when e.g. melodic and dashing are enabled at the same time
  and their generated ros-distro.inc parsed,
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS will contain union of their
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<DISTRO> while still keeping
  the separate list available if we need it for something else

* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

shr-project added a commit to shr-project/superflore that referenced this issue


          Generate recipes in meta-ros-<distro> instead of generated-recipes-<d…

e37257a

…istro>

* yocto_recipe: generate top inherit with specific ROS_DISTRO instead of variable
* this allows to mix layers from different ROS_DISTROs where each recipe
  inherits the right bbclass to set common configuration for its ROS_DISTRO

* yocto_recipe.py: don't generate include lines for various .inc files
* we'll use normal bbappends instead

* bitbake: include ros_version in layer name
* e.g. meta-ros-melodic will be meta-ros1-melodic now

* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

shr-project added a commit to shr-project/superflore that referenced this issue


          yocto_recipe.py: drop ROS_COMPONENT_TYPE

28e7678

* we no longer need to distinguish between ros1 and ros2 components
* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

shr-project added a commit to shr-project/superflore that referenced this issue


          yocto_recipe.py: append to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

ac16785

* define ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<DISTRO>
  and then append it to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

* that way when e.g. melodic and dashing are enabled at the same time
  and their generated ros-distro.inc parsed,
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS will contain union of their
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<DISTRO> while still keeping
  the separate list available if we need it for something else

* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

allenh1 added this to the Version 0.3.1 milestone

shr-project added a commit to shr-project/superflore that referenced this issue


          Generate recipes in meta-ros-<distro> instead of generated-recipes-<d…

2929f7e

…istro>

* yocto_recipe: generate top inherit with specific ROS_DISTRO instead of variable
* this allows to mix layers from different ROS_DISTROs where each recipe
  inherits the right bbclass to set common configuration for its ROS_DISTRO

* yocto_recipe.py: don't generate include lines for various .inc files
* we'll use normal bbappends instead

* bitbake: include ros_version in layer name
* e.g. meta-ros-melodic will be meta-ros1-melodic now

* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

shr-project added a commit to shr-project/superflore that referenced this issue


          yocto_recipe.py: drop ROS_COMPONENT_TYPE

2d7e1a2

* we no longer need to distinguish between ros1 and ros2 components
* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

shr-project added a commit to shr-project/superflore that referenced this issue


          yocto_recipe.py: append to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

31b491d

* define ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<DISTRO>
  and then append it to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

* that way when e.g. melodic and dashing are enabled at the same time
  and their generated ros-distro.inc parsed,
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS will contain union of their
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<DISTRO> while still keeping
  the separate list available if we need it for something else

* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

shr-project added a commit to shr-project/superflore that referenced this issue


          yocto_recipe.py: append to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

ae170c6

* define ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<DISTRO>
  and then append it to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

* that way when e.g. melodic and dashing are enabled at the same time
  and their generated ros-distro.inc parsed,
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS will contain union of their
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<DISTRO> while still keeping
  the separate list available if we need it for something else

* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

shr-project added a commit to shr-project/superflore that referenced this issue


          yocto_recipe.py: append to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

f360bdd

* define ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<DISTRO>
  and then append it to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

* that way when e.g. melodic and dashing are enabled at the same time
  and their generated ros-distro.inc parsed,
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS will contain union of their
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<DISTRO> while still keeping
  the separate list available if we need it for something else

* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

shr-project added a commit to shr-project/superflore that referenced this issue


          yocto_recipe.py: append to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

30d2d86

* define ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<ROS_DISTRO>
  and then append it to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

* that way when e.g. melodic and dashing are enabled at the same time
  and their generated ros-distro.inc parsed,
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS will contain union of their
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<ROS_DISTRO> while still keeping
  the separate list available if we need it for something else

* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

shr-project added a commit to shr-project/superflore that referenced this issue


          yocto_recipe.py: append to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

776cc34

* define ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<ROS_DISTRO>
  and then append it to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

* that way when e.g. melodic and dashing are enabled at the same time
  and their generated ros-distro.inc parsed,
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS will contain union of their
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<ROS_DISTRO> while still keeping
  the separate list available if we need it for something else

* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

shr-project added a commit to shr-project/superflore that referenced this issue


          yocto_recipe.py: append to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

9b49ff3

* define ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<ROS_DISTRO>
  and then append it to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

* that way when e.g. melodic and dashing are enabled at the same time
  and their generated superflore-ros-distro.inc parsed,
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS will contain union of their
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<ROS_DISTRO> while still keeping
  the separate list available if we need it for something else

* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

shr-project added a commit to shr-project/superflore that referenced this issue


          yocto_recipe.py: append to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

d18ea0c

* define ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<ROS_DISTRO>
  and then append it to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

* that way when e.g. melodic and dashing are enabled at the same time
  and their generated superflore-ros-distro.inc parsed,
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS will contain union of their
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<ROS_DISTRO> while still keeping
  the separate list available if we need it for something else

* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

allenh1 closed this as completed in

352d7b3

shr-project added a commit to shr-project/superflore that referenced this issue


          yocto_recipe.py: append to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

6cc32ac

* define ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<ROS_DISTRO>
  and then append it to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

* that way when e.g. melodic and dashing are enabled at the same time
  and their generated superflore-ros-distro.inc parsed,
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS will contain union of their
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<ROS_DISTRO> while still keeping
  the separate list available if we need it for something else

* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

allenh1 pushed a commit that referenced this issue


          yocto_recipe.py: append to ROS_SUPERFLORE_GENERATED_BUILDTOOLS (#259)

ee5e254

* define ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<ROS_DISTRO>
  and then append it to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

* that way when e.g. melodic and dashing are enabled at the same time
  and their generated superflore-ros-distro.inc parsed,
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS will contain union of their
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<ROS_DISTRO> while still keeping
  the separate list available if we need it for something else

* fixes #255

Signed-off-by: Martin Jansa <[email protected]>

zffgithub pushed a commit to zffgithub/superflore that referenced this issue


          Implement changes for meta-ros layer version 3 (part 1) (ros-infrastr…

2bc86cd

…ucture#256)

* Generate recipes under meta-ros-<ROS_DISTRO>

* yocto_recipe: generate top inherit with specific ROS_DISTRO instead of variable
* this allows to mix layers from different ROS_DISTROs where each recipe
  inherits the right bbclass to set common configuration for its ROS_DISTRO

* yocto_recipe.py: don't generate include lines for various .inc files
* we'll use normal bbappends instead

* bitbake: include ros_version in layer name
* e.g. meta-ros-melodic will be meta-ros1-melodic now

* rename the generated ros-distro.inc to superflore-ros-distro.inc

* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

* bitbake: generate SRC_URI with git fetcher instead of unstable github archives

* fixes: ros/meta-ros#609

* github archives are regenerated from time to time with different checksums
  fetch them with git instead

* this allows to simplify the generation quite a bit
* there won't be any issues with top-level directory being named
  differently than ${BP}, because all recipes will use just
  S = ${WORKDIR}/git
* instead of fetching all the archives when generating recipes we'll
  just run "git ls-remote" for them and cache the results (this means
  that if the tag actually moves, then the recipe will still point
  to the old SRCREV)

* this is very specific to exact structure of typical ros package
  fetched from generated github archive, but AFAIK this change doesn't
  make it worse, the generation was already failing for some packages
  like:
  Tarball requested for repo 'tablet_socket_msgs', but I can't parse git URL 'https://gitlab.com/autowarefoundation/autoware.ai-ros-releases/messages-release.git'.
  Falling back on git clone for repo 'tablet_socket_msgs'.
  !!!! Failed generating installer for tablet_socket_msgs! 'tar'
  !!!! 84.4%: Failed to generate installer for package 'tablet_socket_msgs'!

Signed-off-by: Martin Jansa <[email protected]>

* yocto_recipe.py: drop ROS_COMPONENT_TYPE

* we no longer need to distinguish between ros1 and ros2 components
* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

zffgithub pushed a commit to zffgithub/superflore that referenced this issue


          yocto_recipe.py: append to ROS_SUPERFLORE_GENERATED_BUILDTOOLS (ros-i…

a302acd

…nfrastructure#259)

* define ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<ROS_DISTRO>
  and then append it to ROS_SUPERFLORE_GENERATED_BUILDTOOLS

* that way when e.g. melodic and dashing are enabled at the same time
  and their generated superflore-ros-distro.inc parsed,
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS will contain union of their
  ROS_SUPERFLORE_GENERATED_BUILDTOOLS_<ROS_DISTRO> while still keeping
  the separate list available if we need it for something else

* fixes ros-infrastructure#255

Signed-off-by: Martin Jansa <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment