Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ur16e support #477

Merged
merged 4 commits into from
Jun 6, 2020
Merged

Conversation

fmauch
Copy link
Contributor

@fmauch fmauch commented Jan 29, 2020

This PR aims at adding ur16e support to univeral_robot.

This basically implements #460 and UniversalRobots/Universal_Robots_ROS_Driver#73.

It is built upon #371 and #414 so it will have parametrized xacro files and support for robot calibration.

The current status:

  • Add config files for ur16e
  • Add description launch files for ur16e
  • Add gazebo launchfile for ur16e
  • Add meshes of upper and lower arm. To my knowledge all other segments are the same as for the ur10e. The arm segments are also the same, but shortened. So, taking out a part in the middle should be sufficient.
  • Update physical and visual parameters. I started working on those, but many of them are copied from the ur10e
  • Add ur_kinematics files for the ur16e
  • Add ur16_e_moveit_config

@gavanderhoorn
Copy link
Member

@fmauch: would you already want to get this merged into melodic-devel-staging, or would you want to finish the last two items in your list?

I'd be OK with merging this as-is. I'll rebase it on-top of melodic-devel-staging in that case (similar to #495).

@fmauch
Copy link
Contributor Author

fmauch commented Jun 6, 2020

As I'm not very familiar with those two points, I'd be fine with leaving them for a later PR.

Edit:
But it might make sense to merge #495 first and rebase this ontop if that, as this is already with the calibration correction built-in.

@gavanderhoorn
Copy link
Member

As I'm not very familiar with those two points, I'd be fine with leaving them for a later PR.

Ok.

But it might make sense to merge #495 first and rebase this ontop if that, as this is already with the calibration correction built-in.

Yes, that is the plan.

@fmauch
Copy link
Contributor Author

fmauch commented Jun 6, 2020

Rebased this PR

@gavanderhoorn
Copy link
Member

Continued in #496.

@gavanderhoorn
Copy link
Member

Rebased this PR

Apologies @fmauch, I didn't see your comment.

I've opened #496, which is essentially the same.

@gavanderhoorn
Copy link
Member

Would you want us to continue with this one?

Full attribution of the commits is preserved in #496.

@gavanderhoorn gavanderhoorn reopened this Jun 6, 2020
@gavanderhoorn gavanderhoorn changed the base branch from melodic-devel to melodic-devel-staging June 6, 2020 13:17
@gavanderhoorn
Copy link
Member

Merging this without waiting for Travis as we already know this passes CI (from #496).

@gavanderhoorn gavanderhoorn merged commit 1303775 into ros-industrial:melodic-devel-staging Jun 6, 2020
@gavanderhoorn
Copy link
Member

Thanks @fmauch 👍

@gavanderhoorn gavanderhoorn added this to the melodic-devel-staging milestone Jun 16, 2020
@hellohake
Copy link

Hello, I am doing some research on UR16E now.May I ask where can I get the accurate inertial parameters of ur16e now ? and when can the official configuration of UR16_e_moveit_config be released. Thanks~

@fmauch fmauch deleted the ur16e branch May 1, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants