-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor usb cam library with no ros deps #209
Refactor usb cam library with no ros deps #209
Conversation
@twdragon I refactored the code just a bit to be a bit more readable and added the beginning of some unit tests that we can add onto later. The Should we try and template the code? So we could specify a ROS-clock type to use in The second option might be easier to implement, and also give us the benefit of being able to use the |
@flynneva great work! Thank you a lot! Please give me some time to examine the code and adapt it, then it would be also a great unified release! |
c77d952
to
4e967da
Compare
Signed-off-by: Evan Flynn <[email protected]>
Signed-off-by: Evan Flynn <[email protected]>
4e967da
to
7580186
Compare
Signed-off-by: Evan Flynn <[email protected]>
Signed-off-by: Evan Flynn <[email protected]>
Signed-off-by: Evan Flynn <[email protected]>
Signed-off-by: Evan Flynn <[email protected]>
7580186
to
1d7fda4
Compare
@twdragon I added some more tests and I think the To make this happen I had to remove the use of ROS 2 One thing I still am unsure about is how to "simulate" a |
@flynneva great! I will start in some days, thank you for this contribution! I hope to make things work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it makes the code much mere readable. Thank you, and I will do my best to adapt it
acabf65
to
aaf3f13
Compare
@twdragon I squeezed one more change into this PR by adding a simple integration test to round out the first layer of tests we add here. This test can be improved later on once we are able to simulate v4l2 devices on the CI runners. Could you look it over once more and approve? |
232d4f3
to
9f15e49
Compare
Signed-off-by: Evan Flynn <[email protected]>
Signed-off-by: Evan Flynn <[email protected]>
Signed-off-by: Evan Flynn <[email protected]>
Signed-off-by: Evan Flynn <[email protected]>
9f15e49
to
ad88e29
Compare
d2cec78
to
c024178
Compare
Signed-off-by: Evan Flynn <[email protected]>
Signed-off-by: Evan Flynn <[email protected]>
c024178
to
9b8b413
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flynneva great work again! I see an excellent opportunity to recover portability for ROS 1 node too and will have a look very soon! Now I am ready to approve this PR
usb_cam
library to be bit more understandable