Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stuck passive joints #184

Merged
merged 5 commits into from
Dec 16, 2023
Merged

Fix stuck passive joints #184

merged 5 commits into from
Dec 16, 2023

Conversation

huemerj
Copy link
Contributor

@huemerj huemerj commented Oct 4, 2023

This PR is based on ros-controls/gazebo_ros2_control#237 and was tested on a demo with a passive joint (ros-controls/gazebo_ros2_control#172, ported to gz_sim).

@huemerj huemerj requested a review from ahcorde as a code owner October 4, 2023 13:29
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmagyar bmagyar merged commit 0a8d446 into ros-controls:master Dec 16, 2023
4 of 5 checks passed
@christophfroehlich
Copy link
Contributor

@Mergifyio backport iron humble

Copy link
Contributor

mergify bot commented Dec 16, 2023

backport iron humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 16, 2023
* Fix stuck passive joints

* Update comment

* Fix variable naming

---------

Co-authored-by: Christoph Fröhlich <[email protected]>
(cherry picked from commit 0a8d446)
mergify bot pushed a commit that referenced this pull request Dec 16, 2023
* Fix stuck passive joints

* Update comment

* Fix variable naming

---------

Co-authored-by: Christoph Fröhlich <[email protected]>
(cherry picked from commit 0a8d446)
ahcorde pushed a commit that referenced this pull request Dec 16, 2023
* Fix stuck passive joints

* Update comment

* Fix variable naming

---------

Co-authored-by: Christoph Fröhlich <[email protected]>
(cherry picked from commit 0a8d446)

Co-authored-by: Johannes Huemer <[email protected]>
ahcorde pushed a commit that referenced this pull request Dec 16, 2023
* Fix stuck passive joints

* Update comment

* Fix variable naming

---------

Co-authored-by: Christoph Fröhlich <[email protected]>
(cherry picked from commit 0a8d446)

Co-authored-by: Johannes Huemer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants