Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add few compiler warning flags to error #219

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

christophfroehlich
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 51.20%. Comparing base (795b9e6) to head (9f54dec).

Files with missing lines Patch % Lines
src/limited_proxy.cpp 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           ros2-master     #219   +/-   ##
============================================
  Coverage        51.20%   51.20%           
============================================
  Files               10       10           
  Lines              496      496           
  Branches            59       59           
============================================
  Hits               254      254           
  Misses             215      215           
  Partials            27       27           
Flag Coverage Δ
unittests 51.20% <18.18%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/pid.cpp 92.64% <100.00%> (ø)
src/limited_proxy.cpp 0.00% <0.00%> (ø)

src/pid.cpp Show resolved Hide resolved
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich merged commit 7dda65f into ros2-master Nov 6, 2024
25 of 26 checks passed
@christophfroehlich christophfroehlich deleted the add/compile_flags branch November 6, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants