-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NonlinearGradientCorrection in json files from anat #597
Comments
you are right that is is there - just asking to make it bids :-) |
@neurolabusc At least MRI+PET datasets need this tag defined in their MRI images, so one way or another users are going to need to convert from DICOM tags (or |
FYI the reason it came about is that while my wrapper was updating the json for ND (ie corrected) data, I realize that the original needed updated too (because if PET is present that optional field is mandatory not matter corrected or not) -- so if that was added by default then there would be no more issues |
@effigies I would prefer if you decide whether it belongs in dcm2niix or not. I guess my concern is that while it is a convention for Siemens to use |
Just a correction, |
If it can't be reliably determined from the DICOM tags, then I agree that we should not set the field. If there are definitive cases where certain values indicate one way or the other, then it would be appropriate to set the field. Looking at https://cdn0.scrvt.com/39b415fb07de4d9656c7b516d8e2d907/1800000000073846/4a603a47ea58/mr_dicomconformance-00073846_1800000000073846.pdf, ND and DIS2D show up twice and DIS3D once:
I don't really understand what "Not distorted Pixel" and "Distorted Pixel and remapped" mean, but it seems likely that they intend the same code to refer to the same process in multiple places. So we may be able to search for these strings in images we're confident are raw Siemens images. If the |
correct - ND vs DIS2 or DIS3 is what you want to use (for Siemens) |
Sorry, no concrete datasets were provided for validation. The request is to set the NonlinearGradientCorrection field of the BIDS header. Existing versions of dcm2niix does export 0008,0008 as the BIDS "ImageType", so users should be able to query this for DIS3D. |
As I noted above, several of the labels used by Siemens were not described by the DICOM specification for Image Type (0008,0008). With XA30, Siemens now uses the private tag 0021,1175 which future releases of dcm2niix report as the BIDS field However, I remain unsure how to determine if |
so far, curating ~1000 MRI from Trio, Verio, Prisma this has always been the case that ND was the 'standard' image and DIS2D or DIS3D were the corrected images - as reported in |
@CPernet thanks. It is nice to know that 0008,0008 was reliable for various software versions and systems prior to XA30. I have heard direct from Erlangen that moving the |
@effigies I guess this is an issue with the BIDS specification and not |
Also, for documentation purposes in this thread, do we know if this change started with XA10? Is |
@mharms my understanding is that XA10,11,20 use 0008,0008. XA30 and later will use 0021,1175. |
FWIW, whether XA30 differs from XA10,11,20 in terms of the |
@mharms Good point. Proposal here: bids-standard/bids-specification#1160 |
type: Feature request
background: scanners are able to generate distortion corrected anatomical images to account for the small gradient non-linearities.
BIDS-json info: whether the image is corrected or not can be encoded with the key
NonlinearGradientCorrection
set toTrue
orFalse
. It would be great if always set in the json file (even though it is optional in BIDS).Known encoding from Siemens: ImageType tag gives away what we want (0008,0008) ORIGINAL\PRIMARY\M\ND\NORM vs. ORIGINAL\PRIMARY\M\NORM\DIS2D or ORIGINAL\PRIMARY\M\NORM\DIS3D and also the private tag (0051,1016) M/ND/NORM vs p2 M/NORM/DIS2D or M/NORM/DIS3D
The text was updated successfully, but these errors were encountered: