-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add suggestions for API packages #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mpadge could you please review this? I won't merge it before the WIP translation of this chapter is merged. |
mpadge
requested changes
Nov 22, 2022
Co-authored-by: mark padgham <[email protected]>
mpadge
approved these changes
Nov 22, 2022
yabellini
reviewed
Sep 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt how we translate wrapper. It is not in our glossary. I leave it as was translated here, I remember the discussion, but I need to find the decision.
Co-authored-by: Yanina Bellini Saibene <[email protected]>
Co-authored-by: Yanina Bellini Saibene <[email protected]>
Co-authored-by: Yanina Bellini Saibene <[email protected]>
Co-authored-by: Yanina Bellini Saibene <[email protected]>
Co-authored-by: Yanina Bellini Saibene <[email protected]>
Co-authored-by: Yanina Bellini Saibene <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #474
Related to #478
Unsure what should really be in there.