Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advice on user agents? #474

Closed
maelle opened this issue Jun 2, 2022 · 4 comments · Fixed by #496
Closed

Add advice on user agents? #474

maelle opened this issue Jun 2, 2022 · 4 comments · Fixed by #496
Assignees
Milestone

Comments

@maelle
Copy link
Member

maelle commented Jun 2, 2022

Specific to packages wrapping APIs.

Adding an user agent.
Should that user agent be different for package developers themselves and for CI.

@maelle
Copy link
Member Author

maelle commented Jun 10, 2022

Linked to #478 (value added by a wrapper)

@maelle maelle added this to the 0.9.0 milestone Jun 10, 2022
@mpadge
Copy link
Member

mpadge commented Jun 11, 2022

Adding an user agent. Should that user agent be different for package developers themselves and for CI.

This is all very much "in flux". I think use of http2 in particular should translate to a general principle of using the same credentials/agents for CI, but also ensuring everything is redacted via httptest2. For other http systems recommendations would differ. So there seems to currently be a strong dependence of recommendations on http systems, but if we presume a general transition towards http2, then we can also presume a direction of future evolution of our recommendations in this regard.

@maelle
Copy link
Member Author

maelle commented Jun 13, 2022

Thanks! But user agents aren't really confidential info?

  • the package should provide a default user agent
  • the package should let users override it (?)
  • the package might change the user agent based on context (CI, package developers)

Why would that be different when using, say, curl?

@maelle
Copy link
Member Author

maelle commented Nov 8, 2022

EMODnet/emodnet.wfs#125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants