This repository has been archived by the owner on May 10, 2022. It is now read-only.
Switch to FiraCode for syntax font #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me to switch. PR good to merge from my side. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #246 I don't really like our current code font. It looks fancy but I find it difficult to read. For example compare some code with the current font:
Here the ligature joining of the
fiinside the wordfilemake it difficult to read. This is a known problem and there is a PR with a fix on the "open source" Google repo but it has been completely ignored by Google for over 2 years now: googlefonts/spacemono#2What about using FiraCode? It is 100% open source and has ligatures including for
<-, but is a bit more readable.This is what it looks like in FiraCode. Besides being better designed, FiraCode itself is maintained by a nice person who responds to issues and pull requests.