Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ligation and alternate forms so they are not enabled by default #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

InsomniacSoftware
Copy link

The Common Ligatures and Contextual Alternate typography features are enabled by default (at least they are on OSX). With these options enabled, users will be confused when certain glyphs are changed and most will not know how to disable them.

Since SpaceMono is a nice font for programmers, having these features enabled could cause code failures.

So that they will not be enabled by default, but are available to users that wish to use them, this PR is to

  • Change Contextual Alternate (calt) to a Stylistic Set 03 (ss03)
  • Change Common Ligatures (liga) to Discretionary Ligatures (dlig)

Also made some minor changes required for making the ttf files or that threw warnings.

  • Padded Vendor value to 4 characters
  • Bumped FontRevision number
  • Added OBLIQUE line to BoldItalic fontinfo file
  • EOL whitespace removed (by my IDE)

Changed Common Ligatures (liga) to Discretionary Ligatures (dlig),
Padded Vendor value to 4 characters,
Bumped FontRevision number,
Added OBLIQUE line to BoldItalic fontinfo file
@davelab6
Copy link
Member

davelab6 commented Aug 4, 2016

@InsomniacSoftware thanks for this! I chatted to the Colophon team and we all agree this is a good change to make in an upcoming update.

@amckinlay
Copy link

@davelab6 This PR is over a year old. Where is the Colophon team?

@hpapazian
Copy link

@amckinlay Don't hold your breath. I don't think my suggestion from 8/2016* which was supposedly accepted by Colophon ever got implemented. In fact Colophon blocked me on Twitter as a result...

@davelab6
Copy link
Member

davelab6 commented Jan 2, 2018

Thanks for the ping on this. I can't give a specific timeline but I do expect this to ship.

@bluefish6
Copy link

@davelab6 any update on this?

Base automatically changed from master to main March 2, 2021 04:23
@marcelluseasley
Copy link

https://github.com/ToxicFrog/Ligaturizer/releases
This repo has it corrected.

@AntoineKM
Copy link

It would be so nice if @davelab6 could merge this pull request and update this cool font so we could all use it without problems 🥹

@AntoineKM AntoineKM mentioned this pull request Dec 7, 2022
4 tasks
@rpearce
Copy link

rpearce commented Apr 2, 2023

Since it's been almost 7 years since this was opened, we can probably all assume that @davelab6 won't be able to get this merged, so here is what I do when I use Space Mono:

:root {
  font-feature-settings: "liga" 0;
}

and for dynamically fetching, like with document.fonts.add(someFontFace), I do this before adding the font:

const rootStyle = document.querySelector(':root').style;

// Sets my CSS variable for the body font family
rootStyle.setProperty('--type-family-body', `${family}, monospace`);

// Remove when https://github.com/googlefonts/spacemono/pull/2 is resolved
if (family === 'Space Mono') {
  rootStyle.setProperty('font-feature-settings', '"liga" 0');
} else {
  rootStyle.removeProperty('font-feature-settings');
}

I hope this helps somebody!

@hpapazian
Copy link

hpapazian commented Apr 2, 2023

And maybe in another seven years Colophon will provide alternatives to the texture-decimating "M" and "W"...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants