-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ligation and alternate forms so they are not enabled by default #2
base: main
Are you sure you want to change the base?
Conversation
Changed Common Ligatures (liga) to Discretionary Ligatures (dlig), Padded Vendor value to 4 characters, Bumped FontRevision number, Added OBLIQUE line to BoldItalic fontinfo file
@InsomniacSoftware thanks for this! I chatted to the Colophon team and we all agree this is a good change to make in an upcoming update. |
@davelab6 This PR is over a year old. Where is the Colophon team? |
@amckinlay Don't hold your breath. I don't think my suggestion from 8/2016* which was supposedly accepted by Colophon ever got implemented. In fact Colophon blocked me on Twitter as a result... |
Thanks for the ping on this. I can't give a specific timeline but I do expect this to ship. |
@davelab6 any update on this? |
https://github.com/ToxicFrog/Ligaturizer/releases |
It would be so nice if @davelab6 could merge this pull request and update this cool font so we could all use it without problems 🥹 |
Since it's been almost 7 years since this was opened, we can probably all assume that @davelab6 won't be able to get this merged, so here is what I do when I use :root {
font-feature-settings: "liga" 0;
} and for dynamically fetching, like with const rootStyle = document.querySelector(':root').style;
// Sets my CSS variable for the body font family
rootStyle.setProperty('--type-family-body', `${family}, monospace`);
// Remove when https://github.com/googlefonts/spacemono/pull/2 is resolved
if (family === 'Space Mono') {
rootStyle.setProperty('font-feature-settings', '"liga" 0');
} else {
rootStyle.removeProperty('font-feature-settings');
} I hope this helps somebody! |
And maybe in another seven years Colophon will provide alternatives to the texture-decimating "M" and "W"... |
The Common Ligatures and Contextual Alternate typography features are enabled by default (at least they are on OSX). With these options enabled, users will be confused when certain glyphs are changed and most will not know how to disable them.
Since SpaceMono is a nice font for programmers, having these features enabled could cause code failures.
So that they will not be enabled by default, but are available to users that wish to use them, this PR is to
Also made some minor changes required for making the ttf files or that threw warnings.