fix(terser): __filename not defined

[tada5hi]

Rollup Plugin Name: terser

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:
fixes #1366

Description

[tada5hi]

@shellscape would be great if you could have a look on this pr.
The addition to the codeowner file, doesn't seem to have worked.
It shows the following error: "Unknown owner on line 6: make sure @tada5hi exists and has write access to the repository"

[UmamiAppearance]

Without having tested this, the worker thread seem to also take urls.

A simple switch between __filename and import.meta.url should be enough for the different entry points.

---

EDIT:
I was almost right. It works by passing import.meta.url to the URL constructor:

new Worker(new URL(import.meta.url));

But still, an extra import of fileURLToPath is not required.

[jonkoops]

Got an alternative fix for this in #1374. Looks like import.meta.url is transpiled when compiling to CommonJS, so it should remain backwards compatible.

[tada5hi]

Got an alternative fix for this in #1374. Looks like import.meta.url is transpiled when compiling to CommonJS, so it should remain backwards compatible.

can confirm 👍

[jonkoops]

@tada5hi just FYI you can use a keyword in the description of your PR to link it to the issue (see the GitHub documentation). That way it will be closed automatically when the PR is merged.

[tada5hi]

@tada5hi just FYI you can use a keyword in the description of your PR to link it to the issue (see the GitHub documentation). That way it will be closed automatically when the PR is merged.

Oh cool, thank you 😊.

[shellscape]

OK are we in agreement this can be merged?

[jonkoops]

This looks good, no objections from me 👍

[tada5hi]

@shellscape yes from my side.

[shellscape]

Thanks all. This will be automatically published shortly.