-
-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the source maps #1976
Merged
Merged
Fix the source maps #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle size report: Size Change: 0 B
ℹ️ View Details
|
rotu
force-pushed
the
terser
branch
3 times, most recently
from
December 23, 2022 18:35
44de30d
to
dac8e10
Compare
birkskyum
reviewed
Dec 25, 2022
Does it work? |
I think so! |
rotu
changed the title
bump terser plugin and remove --bundleConfigAsCjs
Fix the source maps
Jan 7, 2023
birkskyum
approved these changes
Jan 7, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the darn source maps. Mostly this is bumping terser, but I also added some tests that the sourcemaps are generated correctly and removed some legacy cruft.