Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

480-refactor: Remove css prefixes #655

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

480-refactor: Remove css prefixes #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13dba3f
refactor: 480 - remove prefixed properties
Quiddlee Nov 18, 2024
6333768
fix: 480 - additional info clamp
Quiddlee Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/entities/event/ui/event-card/event-card.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,16 +78,14 @@

.event-additional-info {
overflow: hidden;
display: -webkit-box;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would like to limit additional info with 2 lines, so we need line-clamp: 2, but now it works only with prefix https://caniuse.com/?search=line-clamp

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

-webkit-box-orient: vertical;
-webkit-line-clamp: 2;

max-height: 40px;
margin-top: 0;
margin-bottom: 8px;

font-size: 16px;
text-overflow: ellipsis;
white-space: nowrap;
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/entities/event/ui/event-card/event-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export const EventCard = ({
</section>
<section className={cx('about-event')} data-testid="about-section">
<h2 className={cx('event-title')}>{title}</h2>
<p className={cx('event-additional-info')}>{additionalInfo}</p>
<p title={additionalInfo} className={cx('event-additional-info')}>{additionalInfo}</p>
</section>
</div>

Expand Down
Loading