Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

480-refactor: Remove css prefixes #655

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Quiddlee
Copy link
Member

What type of PR is this? (select all that apply)

  • πŸ• Feature
  • πŸ› Bug Fix
  • 🚧 Breaking Change
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ“ Documentation Update

Description

Related Tickets & Documents

Screenshots, Recordings

Added/updated tests?

  • πŸ‘Œ Yes
  • πŸ™…β€β™‚οΈ No, because they aren't needed
  • πŸ™‹β€β™‚οΈ No, because I need help

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@github-actions github-actions bot changed the title refactor: 480 - remove prefixed properties 480-refactor: Remove css prefixes Nov 18, 2024
@Quiddlee Quiddlee self-assigned this Nov 18, 2024
Copy link
Collaborator

@SpaNb4 SpaNb4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also consider adding this rule?
https://stylelint.io/user-guide/rules/property-no-vendor-prefix/

@@ -78,9 +78,6 @@

.event-additional-info {
overflow: hidden;
display: -webkit-box;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would like to limit additional info with 2 lines, so we need line-clamp: 2, but now it works only with prefix https://caniuse.com/?search=line-clamp

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link

Lighthouse Report:

  • Performance: 99 / 100
  • Accessibility: 99 / 100
  • Best Practices: 100 / 100
  • SEO: 100 / 100

View detailed report

@Quiddlee
Copy link
Member Author

Should we also consider adding this rule? https://stylelint.io/user-guide/rules/property-no-vendor-prefix/

This rule is already applied

Screenshot 2024-11-21 at 10 53 46β€―PM

@SpaNb4
Copy link
Collaborator

SpaNb4 commented Nov 21, 2024

Should we also consider adding this rule? https://stylelint.io/user-guide/rules/property-no-vendor-prefix/

This rule is already applied

Screenshot 2024-11-21 at 10 53 46β€―PM

Are you sure this is coming from stylelint and not your ide?

@Quiddlee
Copy link
Member Author

Should we also consider adding this rule? https://stylelint.io/user-guide/rules/property-no-vendor-prefix/

This rule is already applied
Screenshot 2024-11-21 at 10 53 46β€―PM

Are you sure this is coming from stylelint and not your ide?

it's using stylelint from node_modules and i believe configuration file from our project too

Screenshot 2024-11-21 at 11 55 30β€―PM

@Quiddlee
Copy link
Member Author

Should we also consider adding this rule? https://stylelint.io/user-guide/rules/property-no-vendor-prefix/

This rule is already applied
Screenshot 2024-11-21 at 10 53 46β€―PM

Are you sure this is coming from stylelint and not your ide?

it's using stylelint from node_modules and i believe configuration file from our project too

Screenshot 2024-11-21 at 11 55 30β€―PM

it's somehow doesn't work if i use npm run stylelint even when explicitly define this rule

Screenshot 2024-11-22 at 12 06 33β€―AM

@SpaNb4
Copy link
Collaborator

SpaNb4 commented Nov 25, 2024

it's somehow doesn't work if i use npm run stylelint even when explicitly define this rule

that's weird, but okay
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate adding css prefix library
4 participants