-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
480-refactor: Remove css prefixes #655
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also consider adding this rule?
https://stylelint.io/user-guide/rules/property-no-vendor-prefix/
@@ -78,9 +78,6 @@ | |||
|
|||
.event-additional-info { | |||
overflow: hidden; | |||
display: -webkit-box; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would like to limit additional info with 2 lines, so we need line-clamp: 2
, but now it works only with prefix https://caniuse.com/?search=line-clamp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Lighthouse Report:
|
This rule is already applied |
Are you sure this is coming from stylelint and not your ide? |
it's using |
it's somehow doesn't work if i use |
What type of PR is this? (select all that apply)
Description
Related Tickets & Documents
Screenshots, Recordings
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?