Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbx_dom_lua rojo-rbx/rbx-dom@6ccd30f (custom pivot get/set) #868

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

kennethloeffler
Copy link
Member

This PR closes #866 by bringing changes over from rojo-rbx/rbx-dom@6ccd30f, fixing incorrectness when serving model pivots.

@kennethloeffler kennethloeffler added scope: plugin Relevant to the Roblox Studio plugin size: small impact: medium Moderate issue for Rojo users or a large issue with a reasonable workaround. labels Feb 20, 2024
@Dekkonot Dekkonot merged commit ddb26c7 into rojo-rbx:master Feb 20, 2024
6 checks passed
kennethloeffler added a commit to kennethloeffler/rojo that referenced this pull request Feb 20, 2024
Dekkonot pushed a commit that referenced this pull request Feb 20, 2024
This PR backports some changes to rbx_dom_lua to fix serving model
pivots
@kennethloeffler kennethloeffler deleted the rbx-dom-lua-6ccd30f branch February 21, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: medium Moderate issue for Rojo users or a large issue with a reasonable workaround. scope: plugin Relevant to the Roblox Studio plugin size: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rojo plugin fails to sync model pivots if model does not have a PrimaryPart
2 participants