Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rojo plugin fails to sync model pivots if model does not have a PrimaryPart #866

Closed
kennethloeffler opened this issue Feb 16, 2024 · 0 comments · Fixed by #868
Closed

Rojo plugin fails to sync model pivots if model does not have a PrimaryPart #866

kennethloeffler opened this issue Feb 16, 2024 · 0 comments · Fixed by #868
Assignees
@kennethloeffler
Labels
impact: medium Moderate issue for Rojo users or a large issue with a reasonable workaround. scope: plugin Relevant to the Roblox Studio plugin size: small status: external An external project is the cause of this type: bug Something happens that shouldn't happen

Comments

@kennethloeffler
Copy link
Member

kennethloeffler commented Feb 16, 2024 •
edited
Loading

Rojo currently fails to sync model pivots if the models don't have PrimaryParts. To reproduce, download the following project and follow the steps below: model-pivots.zip

  1. Run rojo serve on the provided project.
  2. Insert the model file in the provided project into Roblox Studio manually.
  3. Connect the Roblox Studio plugin.
  4. Observe that the synced model's transform and pivot properties do not match those of the manually inserted model:

This is caused by an upstream issue in rbx-dom (rojo-rbx/rbx-dom#391), so we'll need to address it over there, then bring the changes over to Rojo. I don't think we'll need to make any actual new releases for the reflection DB for this since it's just an rbx_dom_lua issue
@kennethloeffler kennethloeffler added type: bug Something happens that shouldn't happen size: small impact: medium Moderate issue for Rojo users or a large issue with a reasonable workaround. status: external An external project is the cause of this status: in-progress Someone is working on this last time we checked. labels Feb 16, 2024
@kennethloeffler kennethloeffler self-assigned this Feb 16, 2024
@kennethloeffler kennethloeffler mentioned this issue Feb 16, 2024
Closed
@kennethloeffler kennethloeffler added the scope: plugin Relevant to the Roblox Studio plugin label Feb 17, 2024
@Dekkonot Dekkonot mentioned this issue Feb 19, 2024
Merged
@kennethloeffler kennethloeffler mentioned this issue Feb 20, 2024
Merged
@kennethloeffler kennethloeffler removed the status: in-progress Someone is working on this last time we checked. label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennethloeffler kennethloeffler

Labels
impact: medium Moderate issue for Rojo users or a large issue with a reasonable workaround. scope: plugin Relevant to the Roblox Studio plugin size: small status: external An external project is the cause of this type: bug Something happens that shouldn't happen
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rbx_dom_lua rojo-rbx/rbx-dom@6ccd30f (custom pivot get/set) kennethloeffler/rojo
1 participant
@kennethloeffler