Switch plugin packages back to git submodules #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennethloeffler
changed the title
Dekkonot
approved these changes
May 23, 2023
boatbomber
approved these changes
May 23, 2023
|
@Corecii @Kampfkarren you can write to this repo, right? What do we think, is this PR alright? It unblocks publishing releases (and indeed, last release was not published), so it seems kind of urgent to me! |
|
I think doing this to unblock releases is reasonable. I think we should look to use Wally in the future, but it's missing features that make it easy for us. It would be beneficial to make feature requests on the wally repo for what we need. I can see something like a wally crate with smarter download behavior working fine as part of a build script. |
Corecii
approved these changes
May 25, 2023
|
Hmm, I still can't merge this myself, but thanks for the review! I guess we can wait for kampfkarren to spin through here as well |
Dekkonot
pushed a commit
to UpliftGames/rojo
that referenced
this pull request
Jan 11, 2024
Alright, so I hate to be the one to do this, but rojo-rbx#584 broke crates.io publishing and also caused librojo to be unusable. I see that there was some discussion on Discord shortly after the problem was realized, but there was no action taken. I think keeping librojo and publishing working far, far outweigh any convenience added by Wally. I've kept the same `Packages` naming convention to keep the diff minimal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alright, so I hate to be the one to do this, but #584 broke crates.io publishing and also caused librojo to be unusable. I see that there was some discussion on Discord shortly after the problem was realized, but there was no action taken.
I think keeping librojo and publishing working far, far outweigh any convenience added by Wally.
I've kept the same
Packagesnaming convention to keep the diff minimal.