Switch git submodules to Wally packages #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkargus
reviewed
Jul 22, 2022
imacodr
approved these changes
Jul 25, 2022
mkargus
reviewed
Jul 25, 2022
…ber/rojo into wally-package-management
boatbomber
added
type: tech debt
mkargus
approved these changes
Jul 25, 2022
LPGhatguy
reviewed
Aug 3, 2022
| @@ -2,7 +2,8 @@ | |||
| Defines the errors that can be returned by the reconciler. | |||
| ]] | |||
|
|
|||
| local Fmt = require(script.Parent.Parent.Parent.Fmt) | |||
| local Packages = script.Parent.Parent.Parent.Packages | |||
There was a problem hiding this comment.
This kinda line is why we use FindFirstAncestor("Rojo") a lot. 😅
LPGhatguy
approved these changes
Aug 3, 2022
Kampfkarren
pushed a commit
that referenced
this pull request
May 26, 2023
Alright, so I hate to be the one to do this, but #584 broke crates.io publishing and also caused librojo to be unusable. I see that there was some discussion on Discord shortly after the problem was realized, but there was no action taken. I think keeping librojo and publishing working far, far outweigh any convenience added by Wally. I've kept the same `Packages` naming convention to keep the diff minimal.
Dekkonot
pushed a commit
to UpliftGames/rojo
that referenced
this pull request
Jan 11, 2024
* Switch git submodules to Wally packages * Update build snapshot * Add wally to foreman and use latest versions * Install packages in CI runners * Fix indents * Install packages in the correct directory * Install packages in correct dir of release action too * Remove submodules from ci checkout * Remove submodules from release checkout * Update selene with latest fix * Fix whitespace Co-authored-by: Lucien Greathouse <[email protected]>
Dekkonot
pushed a commit
to UpliftGames/rojo
that referenced
this pull request
Jan 11, 2024
Alright, so I hate to be the one to do this, but rojo-rbx#584 broke crates.io publishing and also caused librojo to be unusable. I see that there was some discussion on Discord shortly after the problem was realized, but there was no action taken. I think keeping librojo and publishing working far, far outweigh any convenience added by Wally. I've kept the same `Packages` naming convention to keep the diff minimal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the git submodules and moves to a more elegant solution with Wally.
Also migrates to @evaera's Promise. No compatibility issues arose, and plugin tests all pass.