Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed WorldPivotData getter/setter to WorldPivot #408

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Changed WorldPivotData getter/setter to WorldPivot #408

merged 1 commit into from
Apr 30, 2024

Conversation

phoriah
Copy link
Contributor

@phoriah phoriah commented Apr 27, 2024

GetPivot / PivotTo don't always reflect the value of WorldPivotData, actual value of which is reflected through WorldPivot (as mentioned in the #179 )
This can be observed by running the following tests in Studio

local Model = Instance.new("Model")
local Part = Instance.new("Part")

Part.Parent = Model

Model.PrimaryPart = Part -- If PrimaryPart doesn't exist then WorldPivot == GetPivot (Pretty sure)

Model.Name = "WPDTest"
Model.Parent = workspace
Model.WorldPivot *= CFrame.new(2.1, 2.3, 2.5) -- Try swapping this with PivotTo

local WorldPivot, GetPivot = Model.WorldPivot, Model:GetPivot()

print(WorldPivot)
warn(GetPivot)
print(WorldPivot == GetPivot)
-- Save the file & see it's contents

@phoriah
Copy link
Contributor Author

phoriah commented Apr 27, 2024

There might be other files that also need changing..

@Dekkonot
Copy link
Member

Believe this is the only file that needs to be changed. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants