Fix secure session using private_id #146
Merged
+149
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepend a version number to match the format of the real private_id hash but keep the plain value visible for ease of debugging tests.
The private_id is to be used as the redis key, public id is to be set in the cookie.
|
Great job! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145.
Addresses CVE-2019-16782
Use the
private_idfromRack::Session::SessionIdadded in rack/rack@cc1d162 as the key to store in redis. This should prevent a timing attack based on session lookup.Fallback on the old redis key as the
public_idso that old sessions continue to work.