Memory leak when closing over ObjectTemplate reference #286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the simplest reproduction of an issue I'm seeing in a larger project, where my app is leaking memory even after the context is closed and the isolate is disposed.
The obvious answer would be "don't close over
global
, useinfo.Context().Global()
or something". But in the more complex reproduction (pprof/leak check) I don't believe it's possible, since I'm hoping to provide a jquery-ish JS api similar to this:This requires js to temporarily retain a reference to a go struct, which I believe comes down to needing a
v8.FunctionCallback
to reference av8.ObjectTemplate
created outside of it.