Move ObjectTemplate leak test into object_template_test.go

since the ignore leaks conditional build was cargo culted from another test file which isn't relevenat here.
rogchap · Feb 11, 2022 · 71fcd86 · 71fcd86
1 parent 102abe5
commit 71fcd86
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 36 deletions.
diff --git a/object_template_leak_test.go b/object_template_leak_test.go
diff --git a/object_template_test.go b/object_template_test.go
@@ -156,3 +156,22 @@ func TestObjectTemplate_garbageCollection(t *testing.T) {
 
 	runtime.GC()
 }
+
+func TestObjectTemplate_leakCheck(t *testing.T) {
+	isolate := v8.NewIsolate()
+	global := v8.NewObjectTemplate(isolate)
+
+	cb := func(info *v8.FunctionCallbackInfo) *v8.Value {
+		// referencing global seems to be the cause of the leak
+		_ = global
+
+		return v8.Null(isolate)
+	}
+
+	global.Set("fn", v8.NewFunctionTemplate(isolate, cb), v8.ReadOnly)
+
+	context := v8.NewContext(isolate, global)
+	context.Close()
+
+	isolate.Dispose()
+}