-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add numerical support #44
base: 0.5.1dev
Are you sure you want to change the base?
Conversation
Bump project dependencies
release version 0.5.1
@sfghuis Thanks, so far it looks good, I'd just suggest changing the cErlangC_generic_variable_list to a dictionary, this way in the future, we won't rely on relative positions for each variable, but instead, we use their names Also, make sure you pull the latest changes from the repo, I see you have a couple of conflicts Let me know if you want me to check something else |
finalize basic testing
@rodrigo-arenas I will work on making the list a dictionary. I hope to finalize the request today |
…work-var-list-to-dict
@rodrigo-arenas Looking forward on your feedback. I added changes notes and updated the dependencies to be inline with your latest version. Would it be ok if I added some error handeling for overflows values after finishing this request? In cases the transactions and intesities cause overflow errors? |
!Do not approve!
Sorry for the late response, I am changing jobs and had different priorities. I added support for pydantic, reduced multi-erlangC and erlangC to single ErlangC. Currently implemented test for the single scenario option and will expand on the mutli-scenario one later.
Aim of the mutli-scenario one is to allow for forecast uncertainties to be included as well, granting better insight into potential staffing requirements.
Could really use some feedback on how to improve the setup.