-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of the yarpdataplayer module #2442
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
(Reminder to myself: the scripts/admin/update-license
and COPYING
file should be updated, since the yarpdataplayer-console
tool is LGPL)
About the indicators library, I'm in favour of including it in YARP, the MIT license is compatible with the BSD-3-Clause, therefore I think it is safe to include the single header version in extern
with a corresponding README.txt
file (see extern/catch
for an example).
Probably you should import also the LICENSE
and LICENSE.termcolor
files.
You might also have a look at the COPYING
file, and see if the MIT license should be mentioned there, but I think it is not required.
This comment has been minimized.
This comment has been minimized.
I'm not sure what's wrong with the CI, the failing builds do not produce any output... let's try rebasing this again |
This comment has been minimized.
This comment has been minimized.
It was some problem on github action, after the rebase everything was built successfully. |
This PR involves a complete refactoring of the yarpdataplayer module. With @vvasco, we implemented the
yarpdataplayer library
in order to separate theGUI
from the processing and thus create aconsole
version of the yarpdataplayer.This has been done following the structure of the other GUI / console modules eg:
yarplogger
andyarpmanager
This PR addresses the following opened issues in YARP concerning the yarpdataplayer:
The new version of the yarpdataplayer has been tested on:
Here are some screenshots:
GUI version
Console version
Aside all the commands available on the
yarpdataplayer
, the user can still make use of the following commands inrpc
:The
yarpdataplayer-console
on the other hand allows the user to:As a further note, not included in the changes that we did for this PR, we wanted to add some progress bars in the console version of the dataplayer to make things clearer, and found this very powerful library.
Before going ahead with this, and including the files as is, @vvasco and me wanted to discuss about a "nicer" way to include this lib into YARP so that other terminal modules such as the yarprobotinterface and other, can make use of it. The licence is MIT so it should be ok, but let's discuss this further if this is deemed interesting for YARP.