Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yarpdataplayer] Provide status flag to check if player has finished playing a loaded dataset #2140

Closed
prashanthr05 opened this issue Dec 4, 2019 · 1 comment

Comments

@prashanthr05
Copy link
Contributor

prashanthr05 commented Dec 4, 2019

Is your feature request related to a problem? Please describe.

When trying to control the yarpdataplayer through a CPP application using the RPC commands, there is no possibility to check if a single run of an entire loaded dataset has completed, while using the play command.

The application prints the following line to the console while the seek bar reaches the end,
asking utils to stop thread.

Additionally, it would be helpful if yarpdataplayer exposed flags like isStopped, isStoppedAtTheEnd, isRunning, etc.

Describe the solution you'd like

A desirable solution could be adding thrift-based functions to check the status flags through the same RPC interface, while internally updating the required status flags hidden from the user.

Describe alternatives you've considered

An alternative that I've considered so far is to use the RPC command step and advance until a boolean false is returned. However, I have not fully understood the implications this might have on the sampling periods of multi-rate sensors datasets.

@drdanz
Copy link
Member

drdanz commented Feb 1, 2021

Fixed by #2442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants