Fix rplidar2 compilation #1792
Merged
Fix rplidar2 compilation #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This static cast is necessary for the compilation because the return value of "wait(..)" is unsigned but EVENT_TIMEOUT = -1. We will keep it until they will fix the bug in the sdk.(fixes robotology#1689)
Nicogene
added
PR Status: Changelog - OK
Some bug in the sdk make impossible to compile it.
drdanz
approved these changes
Jul 12, 2018
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This static cast is necessary for the compilation because the return value of "wait(..)" is unsigned but EVENT_TIMEOUT = -1. We will keep it until they will fix the bug in the sdk.(fixes #1689)
Moreover add NOT APPLE as dependency of the device since some bugs in the sdk make it impossible to compile on macOs(see https://travis-ci.org/robotology/yarp/jobs/402720473 for example)