Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rplidar2 doesn't compile #1689

Closed
Nicogene opened this issue May 17, 2018 · 0 comments · Fixed by #1792
Closed

rplidar2 doesn't compile #1689

Nicogene opened this issue May 17, 2018 · 0 comments · Fixed by #1792
Assignees
@Nicogene
Labels
Affects: YARP v2.3.72 This is a known issue affecting YARP v2.3.72 Component: Devices Fixed in: YARP v3.0.1 Issue Type: Bug Involves some intervention from a system administrator Resolution: Fixed

Comments

@Nicogene
Copy link
Member

Nicogene commented May 17, 2018 •
edited
Loading

Describe the bug
rplidar2 device fail to compile:

/home/ngenesio/yarp/extern/rplidar/sdk/src/rplidar_driver.cpp:528:10: error: case value evaluates to -1, which cannot be narrowed to type 'unsigned long' [-Wc++11-narrowing]
    case rp::hal::Event::EVENT_TIMEOUT:

To Reproduce
Enable ENABLE_yarpmod_rpLidar2

Configuration:

  • OS: linux Kubuntu 16.04
  • yarp version: 2.3.73
  • compiler: clang
@Nicogene Nicogene added Issue Type: Bug Involves some intervention from a system administrator Component: Devices Priority: Normal Affects: YARP v2.3.72 This is a known issue affecting YARP v2.3.72 labels May 17, 2018
@Nicogene Nicogene changed the title No laser device compiles rplidar2 doesn't compile Jul 11, 2018
Nicogene added a commit to Nicogene/yarp that referenced this issue Jul 11, 2018
@Nicogene
rplidar2: fix compilation
30a74e4 
This static cast is necessary for the compilation
because the return value of "wait(..)"
is unsigned but EVENT_TIMEOUT = -1. We will keep
it until they will fix the bug in the sdk.(fixes robotology#1689)
@Nicogene Nicogene mentioned this issue Jul 11, 2018
Merged
@Nicogene Nicogene self-assigned this Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nicogene Nicogene

Labels
Affects: YARP v2.3.72 This is a known issue affecting YARP v2.3.72 Component: Devices Fixed in: YARP v3.0.1 Issue Type: Bug Involves some intervention from a system administrator Resolution: Fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix rplidar2 compilation Nicogene/yarp
1 participant
@Nicogene