Fix for static transforms - and miscellanea #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since in ROS2 the latched behaviour requires a specific QOS configuration, the frameTransformGet_nwc_ros2 tf_static subscription have been modified by passing a QoS profile qith transient local duration policy. Also, two minor changes have been applied: 1)lock in the callbacks, in order to avoid writing transforms in the buffer while a getTransform query is ongoing; 2) The ros2 to yarp time conversion function have been replaced with the one in the Ros2Utils file (simply to avoid code duplication)
randaz81
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since in ROS2 the latched behaviour requires a specific QOS configuration, the frameTransformGet_nwc_ros2 tf_static subscription have been modified by passing a QoS profile qith transient local duration policy.
[The solution to the issue related to the latched topic applied in this PR has been found in the following issue: ROS2#464]
Also, two minor changes have been applied: 1)lock in the callbacks, in order to avoid writing transforms in the buffer while a getTransforms query is ongoing; 2) The ros2 to yarp time conversion function have been replaced with the one in the Ros2Utils file (simply to avoid code duplication)