Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Haptic glove transmission - HapticGloveModule (Recovered PR) #143

Merged
merged 8 commits into from
Jun 25, 2024
Merged

Fix Haptic glove transmission - HapticGloveModule (Recovered PR) #143

merged 8 commits into from
Jun 25, 2024

Conversation

EhsanRanjbari
Copy link
Collaborator

See #139

@EhsanRanjbari EhsanRanjbari added the enhancement New feature or request label May 27, 2024
@EhsanRanjbari EhsanRanjbari requested a review from mebbaid May 27, 2024 08:04
@EhsanRanjbari EhsanRanjbari self-assigned this May 27, 2024
@EhsanRanjbari EhsanRanjbari mentioned this pull request May 27, 2024
Closed
S-Dafarra
S-Dafarra requested changes May 27, 2024
View reviewed changes
app/scripts/ergoCub-Teleoperation-2.xml Outdated Show resolved Hide resolved
app/scripts/ergoCub-Teleoperation-4.xml Outdated Show resolved Hide resolved
@S-Dafarra
Copy link
Collaborator

Hi @EhsanRanjbari, I took a look at the PR and looks good! Well done!

We can wait for the final edits of robotology/wearables#204, then, after a final test on the robot, I think we can merge this!

mebbaid
mebbaid approved these changes Jun 19, 2024
View reviewed changes
.gitignore Show resolved Hide resolved
@EhsanRanjbari
Copy link
Collaborator Author

As mentioned in robotology/wearables#204 (comment), the tests were successful.

@EhsanRanjbari EhsanRanjbari mentioned this pull request Jun 21, 2024
Merged
@EhsanRanjbari
Copy link
Collaborator Author

@S-Dafarra , should we change the version also here?

walking-teleoperation/CMakeLists.txt

Lines 7 to 8 in 3d543c9

project(walking-teleoperation
VERSION 1.3.4)

1.3.5?

@S-Dafarra
Copy link
Collaborator

Yes, that makes sense

@GiulioRomualdi
Copy link
Member

If @mebbaid and @S-Dafarra are ok, you can merge the PR

@S-Dafarra
Copy link
Collaborator

Hi @EhsanRanjbari, could you specify the desired Wearables version in

walking-teleoperation/cmake/WalkingTeleoperationFindDependencies.cmake

Line 156 in afed05e

find_package(IWear QUIET)
and

walking-teleoperation/cmake/WalkingTeleoperationFindDependencies.cmake

Line 159 in afed05e

find_package(WearableActuators QUIET)

@S-Dafarra
Copy link
Collaborator

Thanks @EhsanRanjbari, I will proceed in merging this!

@S-Dafarra S-Dafarra merged commit 82d3dd9 into master Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mebbaid mebbaid mebbaid approved these changes

@S-Dafarra S-Dafarra S-Dafarra approved these changes

@GiulioRomualdi GiulioRomualdi Awaiting requested review from GiulioRomualdi GiulioRomualdi is a code owner

Assignees

@EhsanRanjbari EhsanRanjbari

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EhsanRanjbari @S-Dafarra @GiulioRomualdi @mebbaid