Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bipedal-locomotion-framework: Add missing dependency on UnicyclePlanner #909

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

traversaro
Copy link
Member

While debugging #907, I noticed that the dependency on UnicyclePlanner was missing from bipedal-locomotion-framework. Even if this does not fix #907, it is an issue worth fixing.

@traversaro
Copy link
Member Author

Manual run of the generate-conda-packages job to check if this PR fixes #907 : https://github.com/robotology/robotology-superbuild/actions/runs/1412456203 .

Copy link
Member

@GiulioRomualdi GiulioRomualdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for dealing with that 😃

@traversaro
Copy link
Member Author

Manual run of the generate-conda-packages job to check if this PR fixes #907 : https://github.com/robotology/robotology-superbuild/actions/runs/1412456203 .

Unfortunatly, this will take ~1.15 hours. One reason to go forward with #752 and move yarp to be packaged directly in conda-forge (this would also give us the advantage of having yarp packages on arm64 on Linux and macOS).

@traversaro
Copy link
Member Author

Manual run of the generate-conda-packages job to check if this PR fixes #907 : https://github.com/robotology/robotology-superbuild/actions/runs/1412456203 .

Unfortunatly, this will take ~1.15 hours. One reason to go forward with #752 and move yarp to be packaged directly in conda-forge (this would also give us the advantage of having yarp packages on arm64 on Linux and macOS).

The Linux build was successful!

@traversaro traversaro merged commit ccbf378 into master Nov 2, 2021
@traversaro traversaro deleted the blf-add-missing-dependency-on-unicycle branch November 2, 2021 17:04
Nicogene pushed a commit to Nicogene/robotology-superbuild that referenced this pull request Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conda package generation failure in late October 2021
2 participants