Fix support for zsh in conda binary activation scripts #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please ignore the CI failures, there are usual network non-reproducible issues. The relevant CI job is https://github.com/robotology/robotology-superbuild/actions/runs/982744267, and that was able to produce conda packages. |
|
Friendly ping @lrapetti @Giulero @nunoguedelha (I tagged you as zsh users), as usual there is no need to understand everything in depth in the PR, just checking if it make sense is probably enough. |
lrapetti
approved these changes
Jul 6, 2021
There was a problem hiding this comment.
Thanks @traversaro, sorry but I was AFK last week.
The idea overall seems ok, even if am not aware of some details.
|
Sorry @traversaro , I haven't tried at all yet using |
Nicogene
pushed a commit
to Nicogene/robotology-superbuild
that referenced
this pull request
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #779 . This PR should fix all the
pathappend:3: bad substitutionexperienced by zsh users such as @lrapetti or @Giulero .We temporary install
multishellerfrom a fixed commit to include the required fix mamba-org/multisheller#13 .