-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OsqpEigen, YCM and robot-testing-framework: Switch to use conda-forge binary package when generating conda packages #807
Conversation
To avoid regressions, it is a good idea to run |
89954d6
to
7f5efba
Compare
I did that in https://github.com/robotology/robotology-superbuild/actions/runs/971226693, and indeed it revelated another point that needed to be modified (it is a point where |
I created a new job in https://github.com/robotology/robotology-superbuild/actions/runs/971334957, but it turns out that there was a regression due to #805 . Now
|
As YCM was merged as well in conda-forge (see conda-forge/staged-recipes#15404), I modified the PR to also get ycm-cmake-modules from conda-forge. |
New |
Same for |
iDynTree now fails:
This happens as YCM is a build time dependency for any package depending on YARP or ICUB, but it is does not have any |
This was fixed with the latest two commits. With this commits, the PR is finally able to generate conda packages with no errors: https://github.com/robotology/robotology-superbuild/runs/2931185261 . |
… binary package when generating conda packages (robotology#807)
As osqp-eigen and YCM are now available in conda-forge (see conda-forge/staged-recipes#15309 and https://github.com/conda-forge/osqp-eigen-feedstock) we can now avoid building our own
osqp-eigen
,ycm-cmake-modules
androbot-testing-framework
packages in the robotology channel, and just rely on the one provided byconda-forge
.This is done by defining in
Build<project>.cmake
the<project>_CONDA_PKG_NAME
and<project>_CONDA_PKG_CONDA_FORGE_OVERRIDE
variables, as described in https://github.com/robotology/robotology-superbuild/blob/master/doc/developers-faqs.md#how-to-ensure-that-binary-packages-are-correctly-generated-for-a-new-package . We also removed the<project>_CONDA_DEPENDENCIES
as that was used just in the conda binary generation phase.Part of #752 .