Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding osqp-eigen recipe #15309

Merged
merged 9 commits into from
Jun 23, 2021
Merged

Adding osqp-eigen recipe #15309

merged 9 commits into from
Jun 23, 2021

Conversation

GiulioRomualdi
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

The PR is ready to be reviewed @conda-forge/help-c-cpp

This PR closes #15080
cc @traversaro

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/osqp-eigen) and found some lint.

Here's what I've got...

For recipes/osqp-eigen:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [28, 29, 30, 31]

For recipes/osqp-eigen:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/osqp-eigen) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/stable-baselines3) and found some lint.

Here's what I've got...

For recipes/stable-baselines3:

  • Feedstock with the same name exists in conda-forge.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/osqp-eigen) and found it was in an excellent condition.

@traversaro
Copy link
Contributor

@GiulioRomualdi feel free to add me as well as maintainer, it is a good practice to avoid having just one maintainer in recipes to reduce the bus factor.

@traversaro
Copy link
Contributor

The PR is ready to be reviewed @conda-forge/help-c-cpp

The CI is now green, @conda-forge/help-c-cpp this is now ready for review.

recipes/osqp-eigen/build.sh Outdated Show resolved Hide resolved
Co-authored-by: Silvio Traversaro <[email protected]>
@traversaro
Copy link
Contributor

@wolfv just FYI, this is the first package that we migrate from the robotology channel to conda-forge, hopefully many will follow in the future. : )

@wolfv wolfv merged commit c2ceef5 into conda-forge:master Jun 23, 2021
@wolfv
Copy link
Member

wolfv commented Jun 23, 2021

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Package osqp-eigen
4 participants