-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add portaudio dependency and enable audio-related devices in YARP #499
Conversation
For the members of iCub Tech's Team Code, this PR will mean that from 2020.11 the audio support of YARP should also be directly available in robot-bazaar's Docker images. @vtikha @AlexAntn @ilaria-carlini |
Note that this PR may fail for Windows/Unstable as robotology/ycm-cmake-modules#357 still needs to be propagated to the master branch of ycm, but for that we just need to wait one day. |
There are a few open problems. The Windows compilation is still failing, mainly because we were still using YCM 0.11 as a stable branch, this was fixed in 9e1fb78 . Other problems include: macOSOn macOS, the configuration fails with:
ReleasesThe currently tested release (2020.05 and 2020.08) will be broken as they will not have the necessary fixes in their YCM version. As the 2020.11 release is fast approaching, I think we can simply drop these releases from the |
The macOS problem is due to the fact that
and probably the YCM's |
The rationale is that old releases will be broken by the enabling of portaudio dependencies, see #499 (comment) . For use old releases, it is still possible to checkout the relative tag.
9e1fb78
to
69dbb71
Compare
As this PR have been merged and I bumper the commits of YARP and YCM in the 2020.11 release, I think the PR is finally ready to be merged. |
For YCM and YARP in absence of minor releases with the portaudio fixes (see #499) we get the latest commit from their stable branches. For icub-gazebo and iDynTree we bump to the latest tags.
* Update some releases for the 2020.11 For YCM and YARP in absence of minor releases with the portaudio fixes (see #499) we get the latest commit from their stable branches. For icub-gazebo, icub-models and iDynTree we bump to the latest tags.
This PR add the dependency on portaudio on Linux, macOS and Windows, and enable by default the compilation of the YARP devices related to audio. Fix #284 .