Change the direction of some axes of iCubGenova09 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- l_shoulder_yaw - l_wrist_prosup - l_wrist_pitch - l_wrist_yaw
GiulioRomualdi
changed the title
traversaro
approved these changes
Nov 30, 2020
|
@Nicogene do you think we can merge? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In details it changes:
I added the reverse joints also in the
ICUB_3_upperbody_options.yamlfile but I'm not sure it is used somewhere sinceicub-models-generator/simmechanics/CMakeLists.txt
Lines 407 to 410 in add55e8
It fixes robotology/icub-models#70
cc @prashanthr05 @S-Dafarra @Nicogene @traversaro and @pattacini