[DO NOT MERGE] Add generation of all possible combinations of the dh-generated model #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I found a bug in #162 here. If a new file is generated, it is not properly added to the files that are pushed in icub-models. I will work on a fix. |
|
All the possible combination of options of the legacy generator have been generated in #96 (comment) . This PR has served its purpose, so we can close it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a real pull request, it is just a modification that generates all the possible combination of the DH-based generator, so that we can substitute the generator with just a simple function that takes the correct combination. The model generated by this PR will be generated toward the
last-call-for-dh-generatorbranch of icub-models, were I will collect them and use them.Related issue: #96 .