Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream modifications into vendored Physics system #140

Merged

Conversation

diegoferigo
Copy link
Collaborator

@diegoferigo diegoferigo self-assigned this Feb 12, 2020
@diegoferigo diegoferigo changed the title Merge upstream modification into vendored Physics system Merge upstream modifications into vendored Physics system Feb 12, 2020
@diegoferigo
Copy link
Collaborator Author

diegoferigo commented Feb 12, 2020

I didn't notice that also ign-gazebo received modifications for loading meshes with relative paths to the model. I still have to try, but maybe the file:// prefix could be removed now. The problem was discussed in robotology/gym-ignition-models#2 (comment).

These are the lines about meshes.

Edit: nope, the problem was not this one. Upstream bug in sdformat is still valid.

cc @paolo-viceconte @raffaello-camoriano

@diegoferigo diegoferigo merged commit 10d0abe into robotology-legacy:devel Feb 12, 2020
@diegoferigo diegoferigo deleted the feature/update-physics-system branch February 12, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants