Add disk usage metrics #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey, @isaacseymour thank you so much for this! I'm going to double-check it and get it to release today. |
rnaveiras
reviewed
Apr 13, 2021
| WHERE nspname NOT IN ('pg_catalog', 'information_schema') | ||
| ORDER BY pg_relation_size(C.oid) DESC /*postgres_exporter*/` | ||
|
|
||
| tableUsageQuery = ` |
There was a problem hiding this comment.
@isaacseymour as we discuss this would rewrite this way:
SELECT schemaname
, relname
, pg_table_size(relid)::float
FROM pg_stat_user_tables /*postgres_exporter*/`
This will give us only the table size, including the toast tables and other things, but without the indices size. To get the whole size we can do an aggregation on Prometheus via a recording rule
rnaveiras
reviewed
Apr 13, 2021
rnaveiras
reviewed
Apr 13, 2021
rnaveiras
reviewed
Apr 13, 2021
Signed-off-by: Raúl Naveiras <[email protected]>
rnaveiras
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.