Add stat_activity_oldest_backend_xmin #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwh
commented
Feb 10, 2020
| } | ||
|
|
||
| // postgres_stat_activity_oldest_backend_xmin | ||
| ch <- prometheus.MustNewConstMetric(c.xmin, prometheus.GaugeValue, oldestXmin) |
There was a problem hiding this comment.
I'm pretty sure now that this should be a counter, not a gauge (as long as my assertion about the query that retrieves this metric always holding a snapshot is correct)
Thoughts welcome though
|
@lawrencejones WDYT of this? Have been running it in staging for the past week, although we don't see any of the flat spots there that I think we might in production. |
This is an experiment to see whether this is a useful metric to have: in theory if we see the value of this gauge remain static for a large period of time then we know that there is something running that is preventing the xmin horizon from increasing.
benwh
force-pushed
the
benwh/min-xmin
branch
from
fb1ee25 to
0eb79b4
Compare
|
Now rebased. ping @rnaveiras |
|
@benwh Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment to see whether this is a useful metric to have: in
theory if we see the value of this gauge remain static for a large
period of time then we know that there is something running that is
preventing the xmin horizon from increasing.