Localize default messages #846

miguelcast · 2018-02-16T16:04:05Z

Localize default messages

Add localize prop to Form component for translate messages to different languages. Fixes #1195

Checklist

I'm updating documentation
- I've checked the rendering of the Markdown text I've added
- If I'm adding a new section, I've updated the Table of Content
I'm adding or updating code
- I've added and/or updated tests
- I've updated docs if needed
- I've run npm run cs-format on my branch to conform my code to prettier coding style
I'm adding a new feature
- I've updated the playground with an example use of the feature

edi9999 · 2018-04-05T11:36:52Z

README.md

@@ -1471,6 +1472,21 @@ One consequence of this is that if you have an empty string in your `enum` array

 If you want to have the field set to a default value when empty you can provide a `ui:emptyValue` field in the `uiSchema` object.

+## Localize default messages
+
+You can change localize to default messages errors.


You can change localize to default messages errors.

=>

You can change the localization of the error messages.

edi9999 · 2018-04-05T11:37:12Z

README.md

+
+Here are some examples from the [playground](http://mozilla-services.github.io/react-jsonschema-form/).
+
+Here list of languages support [ajv-i18n](https://github.com/epoberezkin/ajv-i18n).


Here is the list of supported languages ajv-i18n.

edi9999 · 2018-04-05T11:37:30Z

README.md

+```jsx
+render((
+  <Form schema={schema}
+        localize="es" />


localization="es"

edi9999 · 2018-04-05T11:37:43Z

package.json

@@ -1,6 +1,6 @@
 {
  "name": "react-jsonschema-form",
-  "version": "1.0.2",
+  "version": "1.1.2",


please don't change version here.

edi9999 · 2018-04-05T11:39:20Z

Can you add a test showing usage of this new feature ?

I would also like to think if we could add support for localization without adding a dependency to this repo (since it increases the bundle size for each user, despite not using every feature)

pieplu · 2018-12-10T22:09:59Z

src/validate.js

 ) {
  try {
    ajv.validate(schema, formData);
+    localize[local] && localize[local](ajv.errors);


All avji18n will be imported. Why, insted of take a "string" in props, taking a function, that can perform the localization ?
The user (dev?) will can import only needed local function, and pass it.

Suggested change

localize[local] && localize[local](ajv.errors);

localize && localize(ajv.errors);

@miguelcast do you see how it would work here? Then to use the form, we would use the following:

var localize = require('ajv-i18n/localize/ru'); ... <Form localize={localize} ... />

epicfaace · 2019-01-21T18:27:20Z

@miguelcast Can you please make the suggested changes?

# Conflicts: # README.md # package-lock.json

epicfaace

Thanks for your changes. A few more comments.

epicfaace · 2019-01-25T23:59:36Z

src/validate.js

 ) {
  try {
    ajv.validate(schema, formData);
+    localize[local] && localize[local](ajv.errors);


@miguelcast do you see how it would work here? Then to use the form, we would use the following:

var localize = require('ajv-i18n/localize/ru'); ... <Form localize={localize} ... />

test/validate_test.js

Function that receives the errors and you can modify them. Remove ajv-i18n dependency.

epicfaace · 2019-01-28T17:30:14Z

src/components/Form.js

    const { definitions } = this.getRegistry();
    const resolvedSchema = retrieveSchema(schema, definitions, formData);
    return validateFormData(
      formData,
      resolvedSchema,
      validate,
-      transformErrors
+      transformErrors,
+      localization


Why are you returning localization from validateFormData (i.e. what is the use case for doing so)?

epicfaace · 2019-01-28T17:30:49Z

src/components/Form.js

@@ -294,5 +295,6 @@ if (process.env.NODE_ENV !== "production") {
    transformErrors: PropTypes.func,
    safeRenderCompletion: PropTypes.bool,
    formContext: PropTypes.object,
+    localization: PropTypes.func,


Why did you rename it from localize to localization? Just want to hear your thinking on this.

epicfaace · 2019-01-28T17:31:26Z

src/validate.js

@@ -127,7 +127,6 @@ function transformAjvErrors(errors = []) {
  if (errors === null) {
    return [];
  }


Suggested change

}

}

epicfaace · 2019-01-28T17:33:13Z

playground/samples/localization.js

@@ -0,0 +1,53 @@
+const messages = {


This is fine, but you might as well just import a localize function from ajv-i18n rather than writing your own convertMessagesText function for this playground example -- I'm guessing that's simpler? I'd assume that most of the use cases from localization would use an existing function corresponding to a language from ajv-i18n.

epicfaace · 2019-02-23T18:49:33Z

@miguelcast do you have time to respond to my comments and make the requested changes on this?

miguelcast · 2019-02-25T14:48:01Z

@miguelcast do you have time to respond to my comments and make the requested changes on this?

Excuse me for the delay, I thinking finish this feature these days.

epicfaace · 2019-03-16T21:10:25Z

@miguelcast just bumping this!

Maxhy · 2019-06-20T12:35:19Z

@miguelcast any chance to finish this or forward this stuff to someone else? A lot of localized features depends on it and as there is already a pending pull request, we are all waiting for it 😄 . Thanks!

epicfaace · 2019-08-22T16:46:23Z

Anyone is welcome to pick this up if they would like this feature to be added.

epicfaace · 2020-06-02T13:34:47Z

Closing this for now due to inactivity, though this PR could be a good starting point for a later implementation of localization.

IgorLesnevskiy · 2021-01-04T05:35:04Z

@epicfaace what's left to finish here? Guess I could do it.

miguelcast · 2021-01-04T21:02:04Z

@epicfaace what's left to finish here? Guess I could do it.

The issue is long overdue, you have to update the PR and fix the unit tests to be able to finish it.

Bump version 1.1.0

7c33356

miguelcast changed the title ~~Bump version 1.1.0~~ Localize default messages version 1.1.0 Feb 16, 2018

miguelcast added 2 commits February 16, 2018 18:57

Prettier fix

1a02979

Merge branch 'master' into master

6563ec6

edi9999 reviewed Apr 5, 2018

View reviewed changes

README.md Outdated

```jsx

render((

<Form schema={schema}

localize="es" />

Copy link

Collaborator

edi9999 Apr 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

localization="es"

edi9999 reviewed Apr 5, 2018

View reviewed changes

Merge branch 'master' into master

02571a1

pieplu reviewed Dec 10, 2018

View reviewed changes

miguelcast changed the title ~~Localize default messages version 1.1.0~~ Localize default messages Dec 11, 2018

epicfaace added the awaiting changes label Jan 21, 2019

Cognox S.A.S added 2 commits January 25, 2019 11:50

Update last master version

f250154

Merge commit '174e136af4fe728eb79e92594733ea729f3d659f'

c646dbb

# Conflicts: # README.md # package-lock.json

epicfaace requested changes Jan 26, 2019

View reviewed changes

Cognox S.A.S added 4 commits January 28, 2019 10:07

Change localize for localization.

c24173d

Function that receives the errors and you can modify them. Remove ajv-i18n dependency.

Fix test errors messages

64f617d

Fix test errors messages

5bce6c6

Add unit test

050bb27

epicfaace requested changes Jan 28, 2019

View reviewed changes

epicfaace mentioned this pull request Feb 25, 2019

trouble with native compatibility with ajv-i18n #1195

Closed

miguelcast added 4 commits March 18, 2019 07:45

Merge branch 'master' into master

b9d1be5

You can send ajv-i18n localize to localization prop

410c09b

You can send ajv-i18n localize to localization prop

b8f681c

Fix test with validateFormData

800c388

Merge branch 'master' into master

3c54cbb

epicfaace closed this Jun 2, 2020

IgorLesnevskiy mentioned this pull request Jan 5, 2021

Localization for error messages #2189

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Localize default messages #846

Localize default messages #846

miguelcast commented Feb 16, 2018 •

edited by epicfaace

Loading

edi9999 Apr 5, 2018

edi9999 Apr 5, 2018

edi9999 Apr 5, 2018

edi9999 Apr 5, 2018

edi9999 commented Apr 5, 2018

pieplu Dec 10, 2018

kopax Dec 16, 2018

epicfaace Jan 25, 2019

epicfaace commented Jan 21, 2019

epicfaace left a comment

epicfaace Jan 25, 2019

epicfaace Jan 28, 2019

epicfaace Jan 28, 2019

epicfaace Jan 28, 2019

epicfaace Jan 28, 2019

epicfaace commented Feb 23, 2019

miguelcast commented Feb 25, 2019

epicfaace commented Mar 16, 2019

Maxhy commented Jun 20, 2019 •

edited

Loading

epicfaace commented Aug 22, 2019

epicfaace commented Jun 2, 2020

IgorLesnevskiy commented Jan 4, 2021

miguelcast commented Jan 4, 2021


		Here are some examples from the [playground](http://mozilla-services.github.io/react-jsonschema-form/).

		Here list of languages support [ajv-i18n](https://github.com/epoberezkin/ajv-i18n).

	localize[local] && localize[local](ajv.errors);
	localize && localize(ajv.errors);

Localize default messages #846

Localize default messages #846

Conversation

miguelcast commented Feb 16, 2018 • edited by epicfaace Loading