-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localization for error messages #2189
Conversation
waiting so much for this feature! |
@epicfaace How goes the review on this? This feature will help many many people |
@epicfaace Hello, it is possible to fix those little conflicts in order to merge that feature? |
waiting so much for this feature! |
@epicfaace Do you need some help to merge that feature? |
@Ugolaf , yeah, I haven't gotten a chance to do a review yet. Some things that would help is if someone could:
This would really speed up my review, as these are the most time-consuming parts of any review. |
What is the progress on this issue, we are waiting for the feature to be released. |
Игорь, спасибо вам за работу. Подскажите, когда планируется завершить работы по данному PR? Я очень поверхностно знаком с проектом, но если нужна какая-то помощь, готов ее предоставить. Очень хотелось бы иметь данную функциональность в продакшене. |
@v1talii-dev я работал над этим полтора года назад, но, насколько вижу, фичу так и не проревьювили. я могу попробовать разобрать конфликты, но я вообще не помню что там было. кроме того, идет работа над версиюе 5.0.0, возможно там это уже реализовано из коробки. @heath-freenome are you planning to add this feature to the v5? I'm not sure whether I need to resolve the conflicts or not. |
@IgorLesnevskiy I am planning to provide an Ajv 8 version of a validator in the next week or so. I will provide similar capabilities as to what you provided here. I shall add you as a reviewer when I do. I don't believe that adding the feature to the Ajv v6 version of the validator makes sense since that version of Ajv is at the end-of-life. |
@heath-freenome sounds good, thank you! |
@IgorLesnevskiy @heath-freenome thank you all! |
@IgorLesnevskiy Ok, I can't seem to add you as a reviewer, but you can check out the new PR here |
thank you! since there's no need in this mr anymore, I will close it. |
Reasons for making this change
Based on #846. Also, may close #1195.
@epicfaace @edi9999 @pieplu, take a look, please. English is not my mother tongue, so feel free to fix my language in the docs.
Checklist