Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove p tag surrounding submit button #766

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Remove p tag surrounding submit button #766

merged 1 commit into from
Jan 22, 2019

Conversation

ttbarnes
Copy link
Contributor

Reasons for making this change

  • I don't see a need to have a paragraph surrounding a submit button
  • having this wrapping p tag can cause unwanted styles (eg typically a margin)
  • IMO for a submit button, a div is more semantic than a paragraph tag, since it's not a paragraph 😄

Checklist

  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style

@epicfaace
Copy link
Member

LGTM -- what do you think, @glasserc ?

@glasserc glasserc merged commit 2368740 into rjsf-team:master Jan 22, 2019
@glasserc
Copy link
Contributor

Yes, thanks! Sorry for taking so long to get to it!

@ttbarnes ttbarnes deleted the removeSubmitPTag branch January 23, 2019 09:14
KeroVieux added a commit to KeroVieux/react-jsonschema-form that referenced this pull request Jan 25, 2019
* 'master' of github.com:KeroVieux/react-jsonschema-form:
  updated
  replace submit button paragraph tag with div (rjsf-team#766)
  Fixes rjsf-team#824 (rjsf-team#1147)
  Fix bug where matching anyOf branch is not selected correctly (rjsf-team#1129)
  Document a gotcha with `additionalProperties` (rjsf-team#1149)
  doc: add permalinks and fix internal hyperlinks in documentation
  doc: add doc build instructions, update PR/issue templates with doc links
  Add onBlur and onFocus events for radio and checkbox widgets (rjsf-team#1143)
  add ui:help tips (rjsf-team#1145)
  doc: fix browserstack logo size
  docs: remove docs from README and link to readthedocs rjsf-team#1138
  doc: organize docs into separate files rjsf-team#1138
  doc: add browserstack logo rjsf-team#990
  Add test and update documentation for using anyOf inside array items (rjsf-team#1131)

# Conflicts:
#	src/components/Form.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants