Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document a gotcha with additionalProperties #1149

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Document a gotcha with additionalProperties #1149

merged 1 commit into from
Jan 21, 2019

Conversation

loganvolkers
Copy link
Contributor

Replaces #1018

Relates to #848 #902 #992 (and maybe others).

Reasons for making this change

It seems like a lot of people are running into the same problem, this will help them avoid it earlier and be more clear about the current limitations of the library.

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @loganvolkers !

@epicfaace epicfaace merged commit 2685047 into rjsf-team:master Jan 21, 2019
KeroVieux added a commit to KeroVieux/react-jsonschema-form that referenced this pull request Jan 25, 2019
* 'master' of github.com:KeroVieux/react-jsonschema-form:
  updated
  replace submit button paragraph tag with div (rjsf-team#766)
  Fixes rjsf-team#824 (rjsf-team#1147)
  Fix bug where matching anyOf branch is not selected correctly (rjsf-team#1129)
  Document a gotcha with `additionalProperties` (rjsf-team#1149)
  doc: add permalinks and fix internal hyperlinks in documentation
  doc: add doc build instructions, update PR/issue templates with doc links
  Add onBlur and onFocus events for radio and checkbox widgets (rjsf-team#1143)
  add ui:help tips (rjsf-team#1145)
  doc: fix browserstack logo size
  docs: remove docs from README and link to readthedocs rjsf-team#1138
  doc: organize docs into separate files rjsf-team#1138
  doc: add browserstack logo rjsf-team#990
  Add test and update documentation for using anyOf inside array items (rjsf-team#1131)

# Conflicts:
#	src/components/Form.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants