Use setTimeout instead of setImmediate #1482
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
At one place in the library code, we use setImmediate.
However this function is not standard :
Since it is not standard, the setImmediate is transformed by babel to :
var _setImmediate2 = _interopRequireDefault(require("@babel/runtime-corejs2/core-js/set-immediate"));
which adds a lot of unneeded code to the build.In my application tests, we use react-json-schema-form and are mocking the time with lolex, however, this "polyfil" by babel seems to not react to lolex.
setTimeout(function, 0) has the same behavior, it brakes no tests.
It would be great to release a patch version with those changes :-)
Checklist