Use setTimeout instead of setImmediate (#1482)

rjsf-team · Oct 18, 2019 · 95263d1 · 95263d1
1 parent ff3de9b
commit 95263d1
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 11 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/playground/app.js b/playground/app.js
@@ -122,7 +122,7 @@ class GeoPosition extends Component {
   onChange(name) {
     return event => {
       this.setState({ [name]: parseFloat(event.target.value) });
-      setImmediate(() => this.props.onChange(this.state));
+      setTimeout(() => this.props.onChange(this.state), 0);
     };
   }
 
@@ -231,7 +231,7 @@ class Selector extends Component {
     return event => {
       event.preventDefault();
       this.setState({ current: label });
-      setImmediate(() => this.props.onSelected(samples[label]));
+      setTimeout(() => this.props.onSelected(samples[label]), 0);
     };
   };
 
@@ -372,10 +372,10 @@ class App extends Component {
 
   onThemeSelected = (theme, { stylesheet, editor }) => {
     this.setState({ theme, editor: editor ? editor : "default" });
-    setImmediate(() => {
+    setTimeout(() => {
       // Side effect!
       document.getElementById("theme").setAttribute("href", stylesheet);
-    });
+    }, 0);
   };
 
   setLiveSettings = ({ formData }) => this.setState({ liveSettings: formData });

diff --git a/src/utils.js b/src/utils.js
@@ -962,7 +962,7 @@ export function setState(instance, state, callback) {
     instance.setState(state, callback);
   } else {
     instance.setState(state);
-    setImmediate(callback);
+    setTimeout(callback, 0);
   }
 }
 

diff --git a/test/ArrayField_test.js b/test/ArrayField_test.js
@@ -1183,7 +1183,7 @@ describe("ArrayField", () => {
         },
       });
 
-      return new Promise(setImmediate).then(() =>
+      return new Promise(resolve => setTimeout(resolve, 0)).then(() =>
         expect(comp.state.formData).eql([
           "data:text/plain;name=file1.txt;base64,x=",
           "data:text/plain;name=file2.txt;base64,x=",

diff --git a/test/StringField_test.js b/test/StringField_test.js
@@ -1609,7 +1609,7 @@ describe("StringField", () => {
         },
       });
 
-      return new Promise(setImmediate).then(() =>
+      return new Promise(resolve => setTimeout(resolve, 0)).then(() =>
         expect(comp.state.formData).eql(
           "data:text/plain;name=file1.txt;base64,x="
         )
@@ -1640,7 +1640,7 @@ describe("StringField", () => {
         },
       });
 
-      return new Promise(setImmediate).then(() =>
+      return new Promise(resolve => setTimeout(resolve, 0)).then(() =>
         expect(comp.state.formData).eql(
           "data:text/plain;name=" + uriEncodedValue + ";base64,x="
         )

diff --git a/test/utils_test.js b/test/utils_test.js
@@ -1104,7 +1104,7 @@ describe("utils", () => {
       });
     });
 
-    it.only("should 'resolve' and stub out a schema which contains an `additionalProperties` with a type and definition", () => {
+    it("should 'resolve' and stub out a schema which contains an `additionalProperties` with a type and definition", () => {
       const schema = {
         type: "string",
         additionalProperties: {

diff --git a/webpack.config.prod.js b/webpack.config.prod.js
@@ -15,7 +15,7 @@ module.exports = {
     new MonacoWebpackPlugin({
       languages: ['json']
     }),
-    new MiniCssExtractPlugin({filename: "styles.css", allChunks: true}),
+    new MiniCssExtractPlugin({ filename: "styles.css", allChunks: true }),
     new webpack.DefinePlugin({
       "process.env": {
         NODE_ENV: JSON.stringify("production"),