Fix defaults with oneof/anyof and nested dependencies #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually #1293 is not fixed completely yet, working on it |
LucianBuzzo
reviewed
May 31, 2019
src/utils.js
Outdated
| @@ -157,6 +157,16 @@ function computeDefaults(schema, parentDefaults, definitions = {}) { | |||
| defaults = schema.items.map(itemSchema => | |||
| computeDefaults(itemSchema, undefined, definitions) | |||
| ); | |||
| } else if ("oneOf" in schema) { | |||
| schema = | |||
| schema["oneOf"][ | |||
There was a problem hiding this comment.
NIT: This can just be schema.oneOf
LucianBuzzo
reviewed
May 31, 2019
src/utils.js
Outdated
| ]; | ||
| } else if ("anyOf" in schema) { | ||
| schema = | ||
| schema["anyOf"][ |
There was a problem hiding this comment.
NIT: This can just be schema.anyOf
epicfaace
changed the title
epicfaace
changed the title
LucianBuzzo
approved these changes
Jun 2, 2019
epicfaace
commented
Jun 2, 2019
3 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes #1293 - default with oneof/anyof
Fixes #1229, fixes #768 - default with nested dependencies
Checklist
npm run cs-formaton my branch to conform my code to prettier coding style