Default values not set inside allOf

[magaton]

Prerequisites

• I have searched the existing issues
• I understand that providing a SSCCE example is tremendously useful to the maintainers.
• I have read the documentation
• Ideally, I'm providing a sample JSFiddle, Codesandbox.io or preferably a shared playground link demonstrating the issue.

What theme are you using?

mui

Version

5.x

Current Behavior

Default values are not set inside allOf

Expected Behavior

The default values should be set

Steps To Reproduce

playground link

Environment

- OS:
- Node:
- npm:

Anything else?

This is kind of similar to the previously reported issue and pull request that should have fixed the same problem inside oneOf and anyOf.

[heath-freenome]

@magaton Looks like you found another limitation in our allOf and/or if-then-else support. Is this something you are willing to try and fix?

[magaton]

I'd rather keep my qa / user tester hat since I am not a React or front-end developer. Maybe you could state what exactly needs to be done, so somebody can pick it up easier?

[heath-freenome]

Basically our getDefaultFormState() code does not process if-then-else or allOf statements at the moment. Thus additional work needs to happen to support these capabilities

[suman313]

Hi @heath-freenome ,
I would like to work on this issue.
Please assign me this issue.

[monkey-pHy]

Hi @heath-freenome , I would like to work on this issue. Please assign me this issue.

Thanks for your help, I use allOf and have the same issue. I would like to subscibe this issue.

[MarekBodingerBA]

This is a duplicate of my issue: #3832

As there is no response in my thread, I am hijacking this one. I've managed to debug the reason why this happens.

As an temporary fix we created our own fork with the fix and we patch the package to have this functionality as we rely heavily on allOf in our schemas.

The fix has performance implications, from our internal testing getDefaultFormState takes multiples of the original time. It's OK for us, but we had to implement a custom optimization for input fields that commits the value on blur instead of on change.

[heath-freenome]

@MarekBodingerBA Sorry we missed responding to your original issue. Given the solution causes a performance degradation, we definitely would not want to add it as the default behavior. We would definitely be open to adding it as an opt-in feature via a new experimental_defaultFormStateBehavior.allOf flag. Check out the documentation of this capability and let us know whether this is something you'd like to build into the main product for us? I'm guessing that it would be a simple add to your already existing fix. Then you could create a new PR for use to review on the main repo.

[benjdlambert]

@heath-freenome I went ahead and threw all this in a PR. Had some questions about the configuration schema, but seems to fix this issue and my previous issue which turned out to be a duplicate.