-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(over window): pass through Update
s not affecting window function outputs
#19056
Conversation
ensure_delta_in_cache
callUpdate
s not affecting window function outputs
ea11b3a
to
f07a9fa
Compare
5f48086
to
988e6d9
Compare
bdbbc67
to
0d87ab2
Compare
988e6d9
to
41bdd90
Compare
0d87ab2
to
0fc881d
Compare
41bdd90
to
0bd0784
Compare
099e640
to
1eb8388
Compare
0bd0784
to
8495823
Compare
48e3886
to
ca48be1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can now understand if the result of the func call is persisted, this optimization makes sense (sth like MaterializedProject will be similar), but I'm not familiar with the previous impl of OverWindow and why we persisted the func calls here.
Also code is not reviewed, but loc looks good.
So rubber stamp
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
ca48be1
to
13778ee
Compare
…on outputs (#19056) Signed-off-by: Richard Chien <[email protected]>
…on outputs (#19056) Signed-off-by: Richard Chien <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
If an incoming
Update
only changes fields other than partition key, order key and window function arguments, the win func outputs should stay the same. This PR eliminates the redundant re-computation for such kind ofUpdate
s.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.