Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): mv scripts/source e2e_test/source_legacy/basic/scripts #18891

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Oct 14, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Motivation is to fully deprecate old styles and avoid developers adding new tests there.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan changed the title refactor(test): mv refactor(test): mv scripts/source/ e2e_test/source_legacy/basic/scripts/ Oct 14, 2024
@xxchan xxchan requested a review from BugenZhao October 14, 2024 08:01
@xxchan xxchan marked this pull request as ready for review October 14, 2024 08:01
@xxchan xxchan force-pushed the 10-14-refactor_test_mv branch from 58a54f4 to 29a4cdc Compare October 14, 2024 08:04
@xxchan xxchan force-pushed the xxchan/marked-chinchilla branch from be6a9ab to b12b602 Compare October 14, 2024 08:27
@xxchan xxchan force-pushed the 10-14-refactor_test_mv branch 3 times, most recently from 142be41 to 1f4ec34 Compare October 14, 2024 08:39
@xxchan xxchan changed the title refactor(test): mv scripts/source/ e2e_test/source_legacy/basic/scripts/ refactor(test): mv scripts/source e2e_test/source_legacy/basic/scripts Oct 14, 2024
@xxchan xxchan force-pushed the xxchan/marked-chinchilla branch from b12b602 to 99c88c4 Compare October 14, 2024 09:00
@xxchan xxchan force-pushed the 10-14-refactor_test_mv branch 3 times, most recently from a251518 to 7554b24 Compare October 14, 2024 09:29
@xxchan xxchan requested review from stdrc and tabVersion October 14, 2024 09:30
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve for no logic change

Base automatically changed from xxchan/marked-chinchilla to main October 14, 2024 10:06
Copy link

gitguardian bot commented Oct 14, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@xxchan xxchan force-pushed the 10-14-refactor_test_mv branch from 7554b24 to 3cf7f48 Compare October 14, 2024 10:46
@xxchan xxchan enabled auto-merge October 14, 2024 11:11
@xxchan xxchan force-pushed the 10-14-refactor_test_mv branch 2 times, most recently from 00d137b to 991cd95 Compare October 14, 2024 11:59
@graphite-app graphite-app bot requested a review from a team October 14, 2024 13:14
Merged via the queue into main with commit 883bcb1 Oct 14, 2024
30 of 31 checks passed
@xxchan xxchan deleted the 10-14-refactor_test_mv branch October 14, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants