refactor(test): rename non-inline-style e2e_test/source to source_legacy

[xxchan]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

• I have written necessary rustdoc comments
• I have added necessary unit tests and integration tests
• I have added test labels as necessary. See details.
• I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
• My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
• All checks passed in ./risedev check (or alias, ./risedev c)
• My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

• My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

• My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
9425213	Triggered	Generic Password	99c88c4	ci/scripts/e2e-source-test.sh	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[xxchan]

• test: add kafka backfill large data test #18924
• feat: support background DDL for MV on shared source #18919
• feat: enable shared source in session variable by default, and add cluster-level config to disable #18749
• refactor(test): move some tests from source_legacy to source_inline #18894
• refactor(test): mv scripts/source e2e_test/source_legacy/basic/scripts #18891
• refactor(test): rename non-inline-style e2e_test/source to source_legacy #18890 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @xxchan and the rest of your teammates on Graphite

[BugenZhao]

So "legacy" is referring to shared/non-shared, instead of inline/non-inline tests? Can you add some description in PR body?

[xxchan]

So "legacy" is referring to shared/non-shared, instead of inline/non-inline tests? Can you add some description in PR body?

Good question, thanks.

No, "legacy" means non-inline style, not related with shared. Motivation is to fully deprecate old styles and avoid developers adding new tests there.

(Although I gain the motivation from working on shared source. I need to modify some tests, but I'm reluctant to touch legacy tests, and want to modernize them first.)

I found original PR #18870 not trivial to review the diff, so split it into steps.